avoid crash and provide a simple solution for very small log scales#116
avoid crash and provide a simple solution for very small log scales#116elwerene wants to merge 4 commits intoplotters-rs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 66.24% 67.03% +0.78%
==========================================
Files 53 53
Lines 5134 5129 -5
==========================================
+ Hits 3401 3438 +37
+ Misses 1733 1691 -42
Continue to review full report at Codecov.
|
| .floor() as usize; | ||
| if tier_1 == 0 { | ||
| let from = self.logic.start.as_f64().floor() as i32; | ||
| let to = self.logic.end.as_f64().ceil() as i32; |
There was a problem hiding this comment.
Hmm as far as I can see your code does not produce a logarithmic axis, so it is a little inconsistent with existing behavior. I would have expected something like the following.
if tier_1 == 0 {
let from = self.logic.start.as_f64().floor() as i32;
let to = from+1;
return vec![from,to];If I read it correctly, this code should produce an axis with the ticks[10,100] or [100,1000]
In the long run it could be great to allow have several ticks within the same decade on a logarithmic axis:
1,2,5,10,20,50,100... etc
But I think that should be a separate issue.
There was a problem hiding this comment.
Yeah, noticing that too — would prefer to have it in the PR now as maintenance is currently an issue :(
3 participants
When using a log scale from 2 to 8, plotters crashes as tier_1 is zero and is later used as divisor. I made a simple fix by checking for zero tier_1 and providing a simple scale which iterates the integers between both numbers.
I know this is not a complete fix of the problem, especially as a small scale e.g. 0.2 to 0.8 would not show any grid lines, but the best idea a came up with at the moment and it always prevents the crash.
Sorry I had to close (#115) and reopen the pull request, but I did more work and just merging master would be wrong.