Small fix to Histogram2dContour setup in plotly express#5342
Open
gmjw wants to merge 2 commits intoplotly:mainfrom
Open
Small fix to Histogram2dContour setup in plotly express#5342gmjw wants to merge 2 commits intoplotly:mainfrom
gmjw wants to merge 2 commits intoplotly:mainfrom
Conversation
Contributor
Author
|
If a more experienced contributor takes a look at this - I can't understand why the Circle CI build has failed, the error message doesn't indicate anything clearly - any advice appreciated. |
gvwilson
approved these changes
Sep 9, 2025
Contributor
|
thanks @gmjw - much appreciated. the broken Circle CI job isn't your fault - we're working on it… |
Contributor
|
@gmjw This looks great, thanks for the fix. The broken CI job has been fixed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the docs, if
zis passed in with no histfunc, it should be set to'sum':I think this corrects the intended behaviour and puts Histogram2dContour more in line with Histogram2d.
plotly.graph_objects, my modifications concern the code generator and not the generated files.