Open
Conversation
cpsievert
reviewed
Nov 1, 2021
cpsievert
reviewed
Nov 1, 2021
cpsievert
reviewed
Nov 1, 2021
| @@ -0,0 +1,37 @@ | |||
| if(require(tidyquant)){ | |||
Collaborator
There was a problem hiding this comment.
Use testthat::skip_if_not_installed() instead
cpsievert
reviewed
Nov 1, 2021
Comment on lines
+625
to
+633
| #' @export | ||
| to_basic.GeomRectCS <- function(data, ...){ | ||
| to_basic.GeomRect(data, ...) | ||
| } | ||
| #' @export | ||
| to_basic.GeomLinerangeBC <- function(data, ...){ | ||
| data[, c("xend", "y", "yend")] <- data[, c("x", "ymin", "ymax")] | ||
| to_basic.GeomSegment(data, ...) | ||
| } |
Collaborator
There was a problem hiding this comment.
We should probably do more to come up with better hovertext (the tooltip info is basically useless at this point).
Contributor
Author
There was a problem hiding this comment.
I'll look into this
cpsievert
requested changes
Nov 2, 2021
Collaborator
cpsievert
left a comment
cpsievert
left a comment
There was a problem hiding this comment.
See comments/suggestions
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.