chore(docs): update pinecone-import notebook to SDK v8#525
chore(docs): update pinecone-import notebook to SDK v8#525
Conversation
Pin Pinecone Python SDK to ~=8.0 and apply code formatting. Ref: SDK-128
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
CI Status NoteThe CI failures are pre-existing issues in the notebook, not related to the SDK version update in this PR. Lint failures (F821 undefined names): The notebook has This PR's changes:
The pre-existing lint issues should be addressed in a separate PR to properly add the missing imports. |
- Add BytesIO (io), Config/UNSIGNED (botocore.config), ClientError (botocore.exceptions) - Remove unused total_chunks assignment in upload_to_s3 - Resolves F821/F841 lint failures in CI
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "\n", | ||
| "import boto3\n", | ||
| "import pandas as pd\n", | ||
| "from botocore.config import UNSIGNED, Config\n", |
There was a problem hiding this comment.
Incorrect import path for botocore UNSIGNED constant
High Severity
The UNSIGNED constant is incorrectly imported from botocore.config. The UNSIGNED constant is defined at the top level of the botocore module, not in botocore.config. The correct import is from botocore import UNSIGNED while Config remains imported from botocore.config. This will cause an ImportError when the notebook cell executes, preventing the notebook from running successfully.
Summary
~=8.0indocs/pinecone-import.ipynbThis keeps the notebook up to date with the latest SDK version.
Test plan
Related
Note
Low Risk
Low risk documentation/example-only changes; main risk is that notebook runtime behavior changes if the new pinned SDK/API usage diverges from what the notebook expects.
Overview
Updates
docs/pinecone-import.ipynbto pin the Pinecone Python SDK topinecone~=8.0and aligns imports/usage accordingly.Applies formatting and minor cleanup throughout the notebook (import ordering, consistent quoting/line wrapping), and adds missing S3 upload dependencies (
BytesIO,botocoreConfig/UNSIGNED,ClientError) while simplifying the S3 upload helper logic.Written by Cursor Bugbot for commit f247fa8. This will update automatically on new commits. Configure here.