fix: convert errors, return error from match_cmp_type #14
+141
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrsorokin
reviewed
Feb 2, 2026
Shawermik
force-pushed
the
add_errors
branch
2 times, most recently
from
ec08911 to
15a80a8
Compare
alrsorokin
approved these changes
Feb 4, 2026
Collaborator
alrsorokin
left a comment
alrsorokin
left a comment
There was a problem hiding this comment.
пробегись по всему коду где ошибка кладется сначала в переменную
jsonpath.lua
Outdated
|
|
||
| return nil, 'no element matching expression' | ||
| local err = bad_request_error('no element matching expression') | ||
| return nil, err |
Collaborator
There was a problem hiding this comment.
return nil, bad_request_error('no element matching expression')
jsonpath.lua
Outdated
| if count ~= nil and type(count) ~= 'number' then | ||
| return nil, "invalid 'count' argument" | ||
| local err = bad_request_error("invalid 'count' argument") | ||
| return nil, err |
Collaborator
There was a problem hiding this comment.
return nil, bad_request_error("invalid 'count' argument")
jsonpath.lua
Outdated
| if expr == nil or (type(expr) ~= 'string' and type(expr) ~= 'table') then | ||
| return nil, "missing or invalid 'expr' argument" | ||
| local err = bad_request_error("missing or invalid 'expr' argument") | ||
| return nil, err |
Collaborator
There was a problem hiding this comment.
return nil, bad_request_error("missing or invalid 'expr' argument")
potemin1999
force-pushed
the
fix-type-conversion
branch
from
d129e21 to
2bfbe45
Compare
Shawermik
force-pushed
the
add_errors
branch
from
15a80a8 to
2b47ca5
Compare
Shawermik
force-pushed
the
add_errors
branch
from
2b47ca5 to
d699f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.