Skip to content

feat: add custom Docker labels for supporting services #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rshoemaker merged 4 commits into from
Mar 5, 2026
Merged

feat: add custom Docker labels for supporting services #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
305fc7f
feat: add custom Docker labels for supporting services
rshoemaker Mar 4, 2026
3153ac1
fix: add --output.text to explicitly enable default text reporter.
rshoemaker Mar 4, 2026
7b9d3a6
fix: correct flag is "--output.text.path stdout"
rshoemaker Mar 4, 2026
f66389b
fix: linter error
rshoemaker Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ gotestsum=$(gobin)/gotestsum \
$(if $(filter true,$(CI)),--junitfile $@-results.xml)

golangci-lint=$(gobin)/golangci-lint \
$(if $(filter true,$(CI)),--output.junit-xml.path $@-results.xml)
$(if $(filter true,$(CI)),--output.text.path stdout --output.junit-xml.path $@-results.xml)
Copy link
Member

@jason-lynch jason-lynch Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI in case you haven't seen it, CircleCI consumes these files and makes the results available in a dedicated Tests tab. I can see why you'd also want them in the text output, so I'm OK with adding this.


.DEFAULT_GOAL := build

Expand Down
4 changes: 4 additions & 0 deletions api/apiv1/design/database.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ var ServiceSpec = g.Type("ServiceSpec", func() {
g.Example("512M")
g.Meta("struct:tag:json", "memory,omitempty")
})
g.Attribute("orchestrator_opts", OrchestratorOpts, func() {
g.Description("Orchestrator-specific options for this service.")
g.Meta("struct:tag:json", "orchestrator_opts,omitempty")
})

g.Required("service_id", "service_type", "version", "host_ids", "config")
})
Expand Down
2 changes: 2 additions & 0 deletions api/apiv1/gen/control_plane/service.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 15 additions & 0 deletions api/apiv1/gen/http/control_plane/client/encode_decode.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions api/apiv1/gen/http/control_plane/client/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions api/apiv1/gen/http/control_plane/server/encode_decode.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions api/apiv1/gen/http/control_plane/server/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading