Skip to content

refactor: rename common package to healthcheck#282

Merged
jason-lynch merged 1 commit intomainfrom
feat/PLAT-417/core-systemd-resources-pt2
Mar 6, 2026
Merged

refactor: rename common package to healthcheck#282
jason-lynch merged 1 commit intomainfrom
feat/PLAT-417/core-systemd-resources-pt2

Conversation

@jason-lynch
Copy link
Member

Summary

Renames the common package, which only contained a health check interface, to healthcheck. This is to deconflict with a new common package that we'll add in a subsequent PR.

Testing

There should be no functional changes from this PR.

PLAT-417

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This pull request migrates health check types from the common package to a dedicated healthcheck package. The ComponentStatus type and HealthCheckable interface are moved to the new package namespace, with all dependent files updated to reference the relocated definitions.

Changes

Cohort / File(s) Summary
Healthcheck Package Definition
server/internal/healthcheck/healthcheck.go
Renamed package declaration from common to healthcheck, changing the namespace for exported ComponentStatus type.
Docker Integration
server/internal/docker/docker.go
Updated imports and changed interface assertion and method signature to use healthcheck.HealthCheckable and healthcheck.ComponentStatus.
Etcd Integration
server/internal/etcd/interface.go, server/internal/etcd/embedded.go, server/internal/etcd/remote.go
Updated imports and changed interface embeddings and method signatures across etcd components to reference healthcheck.HealthCheckable and healthcheck.ComponentStatus.
Host Status Handling
server/internal/host/host.go, server/internal/host/host_status_store.go, server/internal/host/service.go
Updated imports and changed Components field types from map[string]common.ComponentStatus to map[string]healthcheck.ComponentStatus in HostStatus and StoredHostStatus types.
Orchestrator Integration
server/internal/orchestrator/swarm/orchestrator.go
Updated imports and changed component status type from common.ComponentStatus to healthcheck.ComponentStatus in PopulateHostStatus.

Poem

🐰 ✨ Hop, hop, hurray! The types have moved,
From common grounds to healthcheck grooves,
A cleaner path, more focused still,
Where wellness checks bend to their will,
PackagesMigrate with rabbity zeal!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description covers the Summary and Testing sections but omits several required sections including Changes, Checklist items, and Notes for Reviewers. Expand the description to include a bulleted Changes section detailing modified files, complete the Checklist with appropriate selections, and add any relevant Notes for Reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: renaming the common package to healthcheck to avoid future conflicts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/PLAT-417/core-systemd-resources-pt2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jason-lynch
Copy link
Member Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jason-lynch jason-lynch force-pushed the feat/PLAT-417/core-systemd-resources-pt1 branch from ea3333e to 7c2858e Compare March 3, 2026 15:03
@jason-lynch jason-lynch force-pushed the feat/PLAT-417/core-systemd-resources-pt2 branch from cce50f9 to 33e99fc Compare March 3, 2026 15:04
@jason-lynch jason-lynch force-pushed the feat/PLAT-417/core-systemd-resources-pt1 branch from 7c2858e to e320e28 Compare March 3, 2026 15:05
@jason-lynch jason-lynch force-pushed the feat/PLAT-417/core-systemd-resources-pt2 branch from 33e99fc to 8c5edbb Compare March 3, 2026 15:06
@mmols mmols self-requested a review March 5, 2026 16:54
@jason-lynch jason-lynch force-pushed the feat/PLAT-417/core-systemd-resources-pt1 branch 2 times, most recently from 72b56b1 to 522c473 Compare March 6, 2026 13:59
Base automatically changed from feat/PLAT-417/core-systemd-resources-pt1 to main March 6, 2026 14:49
This is to deconflict with a new `common` package that we'll add in a
subsequent PR.

PLAT-417
@jason-lynch jason-lynch force-pushed the feat/PLAT-417/core-systemd-resources-pt2 branch from 8c5edbb to 62341c7 Compare March 6, 2026 14:50
@jason-lynch jason-lynch merged commit 72b01b5 into main Mar 6, 2026
2 checks passed
@jason-lynch jason-lynch deleted the feat/PLAT-417/core-systemd-resources-pt2 branch March 6, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants