Skip to content

Comments

[IGNORE] Skip Go linting for schemaless plugins#578

Merged
Nexucis merged 2 commits intoperses:mainfrom
rickardsjp:skip-go-lint-for-frontend-plugins
Feb 20, 2026
Merged

[IGNORE] Skip Go linting for schemaless plugins#578
Nexucis merged 2 commits intoperses:mainfrom
rickardsjp:skip-go-lint-for-frontend-plugins

Conversation

@rickardsjp
Copy link
Contributor

@rickardsjp rickardsjp commented Feb 20, 2026

Description

Plugins like the LogExplorer (#577) that only provide frontend components (Explore views) don't have a schemas/ directory and therefore no Go files and should be skipped.

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

For example, plugins like LogExplorer that only provide frontend
components (Explore views) don't have a `schemas/` directory and should
be skipped.

Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
@rickardsjp rickardsjp force-pushed the skip-go-lint-for-frontend-plugins branch from 2e6c768 to 881f2b5 Compare February 20, 2026 10:26
@rickardsjp rickardsjp changed the title [IGNORE] Skip Go linting for plugins with no Go SDK [IGNORE] Skip Go linting for schemaless plugins Feb 20, 2026
@rickardsjp rickardsjp force-pushed the skip-go-lint-for-frontend-plugins branch from afc9079 to 77335e6 Compare February 20, 2026 11:28
Co-authored-by: Augustin Husson <husson.augustin@gmail.com>
Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
@rickardsjp rickardsjp force-pushed the skip-go-lint-for-frontend-plugins branch from 77335e6 to a7d9019 Compare February 20, 2026 11:44
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @rickardsjp

@Nexucis Nexucis added this pull request to the merge queue Feb 20, 2026
Merged via the queue into perses:main with commit a719222 Feb 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants