BUGFIX: Make join operation thread safe#46
Merged
prasadlohakpure merged 2 commits intomainfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition in the join task that occurred when task_concurrency > 1. Multiple concurrent goroutines were accessing and modifying a shared buffer field on the join struct, causing non-deterministic behavior and data corruption.
Changes:
- Moved buffer storage from struct field to local variable in Run() method to eliminate race condition
- Updated flushBuffer and sendJoinedRecords methods to accept buffer as parameter instead of accessing it from struct
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
divyanshu-tiwari
approved these changes
Feb 23, 2026
Mayureshpawar29
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make join operation thread safe
Why:
If task_concurreny is added to join task by a user, ambiugious behaviour may occur due to race condition on shared
buffer.Types of changes
Testing :
file: test/pipelines/join.yaml
With
task_concurrenyset to 2 or more:Before changes(is task_concurreny was implemented):
Non deterministic behaviour
e.g. Data written multiple times
(
Adeleappearing multiple times)After changes:
No loss in data, all records from names.txt present in output have just one occurence
Checklist