remove text-indent for headings in mobile#51
Open
paradite wants to merge 1 commit intopages-themes:masterfrom
Open
remove text-indent for headings in mobile#51paradite wants to merge 1 commit intopages-themes:masterfrom
paradite wants to merge 1 commit intopages-themes:masterfrom
Conversation
|
Welcome! Congrats on your first pull request to the Architect theme. If you haven't already, please be sure to check out the contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
text-indentwas introduced for compensating the blue ticks before the headingsarchitect/_sass/jekyll-theme-architect.scss
Line 197 in 27f3b20
They were not removed in mobile, whereas the blue ticks were removed
architect/_sass/jekyll-theme-architect.scss
Lines 377 to 379 in 27f3b20
This results in extra indentation in mobile.
Solution
This css change removes unnecessary
text-indentin mobile.Before / After
Using my own page because I am a bit lazy for reproducing this...
live website effect reference: https://retire35.com/