Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
commented
Feb 13, 2026
| onSuccess(updatedRules) { | ||
| const newRule = updatedRules.rules[updatedRules.rules.length - 1] | ||
| // We just appended a rule, so the response list is non-empty | ||
| const newRule = updatedRules.rules.at(-1)! |
Collaborator
Author
There was a problem hiding this comment.
this changes nothing, it just came up when I did an audit of things that fail when we turn on noUncheckedIndexAccess and I changed it to use at because it's shorter
0cbf402 to
dbd63c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://devblogs.microsoft.com/typescript/typescript-native-port/
https://github.com/microsoft/typescript-go
We still have to keep the regular typescript dep installed because some libraries depend on it, but we can use
tsgofor all our actual typechecking. I changed thetscscript to calltsgosince eventuallytsgois going to be released astsc(I think).