chore: temporary banner update for Vite+ Alpha announcement#973
chore: temporary banner update for Vite+ Alpha announcement#973
Conversation
✅ Deploy Preview for oxc-project ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8bcb8c513
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: latestBlog.link, | ||
| text: `Announcing ${latestBlog.text}`, | ||
| url: latestBlog.link, | ||
| id: "viteplus-alpha", |
There was a problem hiding this comment.
This change hardcodes themeConfig.banner.id to "viteplus-alpha", but the pre-hydration bannerScript still reads from localStorage using latestBlog.link, so the script now checks a different dismissal key than the banner it renders. In the Vite+ announcement window, users who dismiss the new banner can still get the banner shown briefly before hydration because banner-dismissed is not applied from the correct key on initial load.
Useful? React with 👍 / 👎.
1 participant
Merge after Vite+ Alpha post is published: https://voidzero.dev/posts/announcing-vite-plus-alpha