feature: support etcd as data source.#292
Open
EasonFeng5870 wants to merge 34 commits intoorlabs:masterfrom
Open
feature: support etcd as data source.#292EasonFeng5870 wants to merge 34 commits intoorlabs:masterfrom
EasonFeng5870 wants to merge 34 commits intoorlabs:masterfrom
Conversation
add etcd supported methods.
1. add get ip address method; 2. refactor dao for support etcd and mysql.
method of compose_plugin_data is too long, need refact it. Co-Authored-By: WangKai <oracle219@gmail.com>
modify init and init_work method, load data source according to configurations. Co-Authored-By: WangKai <oracle219@gmail.com> Co-Authored-By: redzippo1 <redzippo@foxmail.com>
remove unused variables and modify code style.
2. rename mysql_store.lua to store.lua 3. add some variable to store.lua
This reverts commit 2288245.
1. move mysql_db.lua, mysql_store.lua to mysql package. 2. rename mysql_store.lua to store.lua 3. add some variable to store.lua
Update code.
sumory
reviewed
Sep 18, 2019
Collaborator
sumory
left a comment
sumory
left a comment
There was a problem hiding this comment.
.tar.gz这样的文件最好不要提交到仓库作为git的一部分
Contributor
Author
好的，我看看如何弄一下，谢谢。 |
Collaborator
|
相关文档可以更新到 README @EasonFeng5870 |
shuaijinchao
changed the title
|
I think it is very necessary to add some test case coverage. |
Contributor
Author
|
Need more time to optimization, pls wait for a while, thanks~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1:make data source able to switch by configuration in orange.conf file.
2:support ETCD data source.