Automated - Update config ./config/openshift.yaml #3264
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughRemoved OKD Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
/retest-required @cpmeadors / @neisw This add the periodic job from PR openshift/release#74043 to sippy |
|
Scheduling required tests: |
|
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
d521ef2 to
265c687
Compare
|
Scheduling required tests: |
openshift-bot
force-pushed
the
automated---update-config-./config/openshift.yaml
branch
from
265c687 to
6ed0a83
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/variantregistry/snapshot.yaml`:
- Around line 280238-280261: The Release fields for the job key
periodic-ci-stackrox-stackrox-release-4.9-ocp-4-21-lp-interop-cr-acs-tests-aws
are incorrect for OCP 4.21; update the Release, ReleaseMajor, and ReleaseMinor
values to reflect the OCP version used by the job (set Release to "4.21",
ReleaseMajor to "4", and ReleaseMinor to "21") so they match the OCP version in
the job name.
| periodic-ci-stackrox-stackrox-release-4.9-ocp-4-21-lp-interop-cr-acs-tests-aws: | ||
| Aggregation: none | ||
| Architecture: amd64 | ||
| CGroupMode: v2 | ||
| ContainerRuntime: runc | ||
| FeatureSet: default | ||
| Installer: ipi | ||
| JobTier: candidate | ||
| LayeredProduct: lp-interop-acs | ||
| Network: sdn | ||
| NetworkAccess: default | ||
| NetworkStack: ipv4 | ||
| OS: rhcos9 | ||
| Owner: mpiit | ||
| Platform: aws | ||
| Procedure: none | ||
| Release: "4.9" | ||
| ReleaseMajor: "4" | ||
| ReleaseMinor: "9" | ||
| Scheduler: default | ||
| SecurityMode: default | ||
| Suite: unknown | ||
| Topology: ha | ||
| Upgrade: none |
There was a problem hiding this comment.
Release field appears inconsistent with OCP version in job name.
The job name periodic-ci-stackrox-stackrox-release-4.9-ocp-4-21-lp-interop-cr-acs-tests-aws indicates this runs StackRox release 4.9 on OCP 4.21. However, the Release, ReleaseMajor, and ReleaseMinor fields are set to "4.9", "4", and "9" respectively.
Comparing with similar layered product entries (e.g., konveyor at line 3428 which has Release: "4.21" for an OCP 4.21 job), the Release field should track the OCP version, not the product version.
🔧 Suggested fix to align Release with OCP version
Platform: aws
Procedure: none
- Release: "4.9"
+ Release: "4.21"
ReleaseMajor: "4"
- ReleaseMinor: "9"
+ ReleaseMinor: "21"
Scheduler: default📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| periodic-ci-stackrox-stackrox-release-4.9-ocp-4-21-lp-interop-cr-acs-tests-aws: | |
| Aggregation: none | |
| Architecture: amd64 | |
| CGroupMode: v2 | |
| ContainerRuntime: runc | |
| FeatureSet: default | |
| Installer: ipi | |
| JobTier: candidate | |
| LayeredProduct: lp-interop-acs | |
| Network: sdn | |
| NetworkAccess: default | |
| NetworkStack: ipv4 | |
| OS: rhcos9 | |
| Owner: mpiit | |
| Platform: aws | |
| Procedure: none | |
| Release: "4.9" | |
| ReleaseMajor: "4" | |
| ReleaseMinor: "9" | |
| Scheduler: default | |
| SecurityMode: default | |
| Suite: unknown | |
| Topology: ha | |
| Upgrade: none | |
| periodic-ci-stackrox-stackrox-release-4.9-ocp-4-21-lp-interop-cr-acs-tests-aws: | |
| Aggregation: none | |
| Architecture: amd64 | |
| CGroupMode: v2 | |
| ContainerRuntime: runc | |
| FeatureSet: default | |
| Installer: ipi | |
| JobTier: candidate | |
| LayeredProduct: lp-interop-acs | |
| Network: sdn | |
| NetworkAccess: default | |
| NetworkStack: ipv4 | |
| OS: rhcos9 | |
| Owner: mpiit | |
| Platform: aws | |
| Procedure: none | |
| Release: "4.21" | |
| ReleaseMajor: "4" | |
| ReleaseMinor: "21" | |
| Scheduler: default | |
| SecurityMode: default | |
| Suite: unknown | |
| Topology: ha | |
| Upgrade: none |
🤖 Prompt for AI Agents
In `@pkg/variantregistry/snapshot.yaml` around lines 280238 - 280261, The Release
fields for the job key
periodic-ci-stackrox-stackrox-release-4.9-ocp-4-21-lp-interop-cr-acs-tests-aws
are incorrect for OCP 4.21; update the Release, ReleaseMajor, and ReleaseMinor
values to reflect the OCP version used by the job (set Release to "4.21",
ReleaseMajor to "4", and ReleaseMinor to "21") so they match the OCP version in
the job name.
|
Scheduling required tests: |
|
@openshift-bot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
/cc @
Summary by CodeRabbit
Release Notes