OCPBUGS-79422: fix single interface uplink validation in NNCP wizard

[upalatucci]

Summary

• Fix the "Next" button being permanently disabled when selecting a NIC in the "A single interface" uplink connection option of the NNCP creation wizard.
• The validation expected exactly 1 bridge port, but selecting a NIC sets 2 ports (physical NIC + OVS internal interface ovs-br1). Updated NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK from 1 to 2.
• This also fixes a secondary issue where the "Next" button was incorrectly enabled before any NIC was selected.

DEMO

Screen.Recording.2026-03-24.at.20.45.02.mov

Test plan

• Create NNCP from form
• Move to Uplink connection and select "A single interface"
• Select an interface — verify the "Next" button is now enabled
• Verify that before selecting any NIC, the "Next" button is disabled

Made with Cursor

[openshift-ci-robot]

@upalatucci: This pull request references Jira Issue OCPBUGS-79422, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Fix the "Next" button being permanently disabled when selecting a NIC in the "A single interface" uplink connection option of the NNCP creation wizard.
• The validation expected exactly 1 bridge port, but selecting a NIC sets 2 ports (physical NIC + OVS internal interface ovs-br1). Updated NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK from 1 to 2.
• This also fixes a secondary issue where the "Next" button was incorrectly enabled before any NIC was selected.

Test plan

• Create NNCP from form
• Move to Uplink connection and select "A single interface"
• Select an interface — verify the "Next" button is now enabled
• Verify that before selecting any NIC, the "Next" button is disabled

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bf3bf59e-52dc-4e43-a89c-f88fcdb69370

📥 Commits

Reviewing files that changed from the base of the PR and between d597f71 and 8ac1c53.

📒 Files selected for processing (1)

• src/utils/components/PolicyForm/PolicyWizard/utils/constants.ts

---

Walkthrough

A single numeric constant value is updated in the PolicyWizard utilities. The NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK constant is changed from 1 to 2, affecting the threshold used for determining single interface uplink configurations.

Changes

Cohort / File(s)	Summary
PolicyWizard Constants src/utils/components/PolicyForm/PolicyWizard/utils/constants.ts	Updated NUM_INTERFACES_FOR_SINGLE_INTERFACE_UPLINK constant value from 1 to 2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pcbailey]

/retest

[openshift-ci]

@upalatucci: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-tests	8ac1c53	link	true	/test e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.