OKD-259: Add Validatation for the OKD Featureset to Prevent it From Being Enabled on OCP Clusters #10260
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jatinsu: This pull request references OKD-259 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jatinsu
force-pushed
the
OKD-featuregates
branch
from
e971efd to
fccddc3
Compare
tthvo
left a comment
tthvo
left a comment
There was a problem hiding this comment.
/lgtm
Local testing worked as expected and unit tests also shows that.
$ go test -tags=scos -v -run "TestFeatureGates/OKD_featureset" ./pkg/types/validation/
=== RUN TestFeatureGates
=== RUN TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer
--- PASS: TestFeatureGates (0.00s)
--- PASS: TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer (0.00s)
PASS
ok github.com/openshift/installer/pkg/types/validation 0.021s
$ go test -v -run "TestFeatureGates/OKD_featureset" ./pkg/types/validation/
=== RUN TestFeatureGates
=== RUN TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer
--- PASS: TestFeatureGates (0.00s)
--- PASS: TestFeatureGates/OKD_featureset_requires_SCOS-compiled_installer (0.00s)
PASS
ok github.com/openshift/installer/pkg/types/validation 0.021s
|
/cc @patrickdillon |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/verified by unit |
openshift-ci-robot
added
the
verified
|
@patrickdillon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Revision fccddc3 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/skip |
|
/hold Revision fccddc3 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold Revision fccddc3 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel Jobs are having problems to build images. I'd give another run... If not, I think we are OK to override the openstack job as it already passed for the same commit in previous run. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test okd-scos-images |
|
/test e2e-openstack-ovn |
|
/override ci/prow/e2e-openstack-ovn failures don't look related to this pr, other openstack tests are passing.... |
|
@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-openstack-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
commands I ran: go get github.com/openshift/api@latest go get github.com/openshift/client-go@latest go mod tidy go mod vendor
This check only allows the OKD featureset to be enabled in the install-config when the installer is compiled using `TAGS=scos hack/build.sh`
jatinsu
force-pushed
the
OKD-featuregates
branch
from
fccddc3 to
ceb0088
Compare
openshift-ci-robot
removed
the
verified
|
@tthvo @patrickdillon Sorry could we get a lgtm/approval for this again. Needed to rebase since there were merge conflicts :) I appreciate you guys being on top of this so far! |
|
/skip |
|
/verified by unit |
openshift-ci-robot
added
the
verified
|
@tthvo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override e2e-openstack-ovn e2e-metal-ipi-ovn-ipv6 Unrelated failures :( |
|
@tthvo: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-openstack-ovn ci/prow/e2e-metal-ipi-ovn-ipv6 |
|
@tthvo: Overrode contexts on behalf of tthvo: ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-openstack-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jatinsu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn |
4 participants
The newly introduced OKD feature set should not be enabled on OCP clusters. This PR introduces this and throws an error if a user has the OKD featureset enabled in the install-config and if the installer isn't compiled for scos (
TAGS=scos hack/build.sh)