-
Notifications
You must be signed in to change notification settings - Fork 670
OCPBUGS-74506: Remove ConsolePluginSecurityPolicy featuregate #16013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jhadvig: This pull request references Jira Issue OCPBUGS-74506, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThe pull request updates the vendored OpenShift API dependency source from github.com/openshift/api to github.com/jhadvig/api with new pseudo-versions. It introduces KMSEncryption feature gate annotations to the API server configuration, removes the ConsolePluginContentSecurityPolicy feature gate from console plugins, and updates enum validation metadata for ConsoleSampleSourceType. Documentation comments and Swagger descriptions across authentication, infrastructure, and API server types are reformatted for clarity. Platform type enumerations are expanded to include IBMCloud and External options, and machine configuration validation rules are refined to enforce stricter constraints on managed boot images in Automatic mode. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
/retest |
|
@jhadvig: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
This PR needs to get merged together with console-operator PR in order to get openshift/api#2683 merged
/assign @TheRealJon
@spadgett FYI
Summary by CodeRabbit
New Features
Deprecations
Improvements