Fix issue with AsynchronousSocketChannel on Windows#142
Draft
earocorn wants to merge 2 commits intoopensensorhub:masterfrom
Draft
Fix issue with AsynchronousSocketChannel on Windows#142earocorn wants to merge 2 commits intoopensensorhub:masterfrom
earocorn wants to merge 2 commits intoopensensorhub:masterfrom
Conversation
Collaborator
Author
|
Keep the previous implementation for linux/macOS and add a check to use a queue for windows systems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows does not handle concurrent writes in AsynchronouSocketChannel well enough, so this uses a queue for writing.