O3-5459: Void/purge queue entries when associated visit is voided or purged#96
Open
O3-5459: Void/purge queue entries when associated visit is voided or purged#96
Conversation
…purged Add VisitWithQueueEntriesDeleteAdvice AOP advisor that intercepts VisitService.voidVisit() and VisitService.purgeVisit() to ensure associated queue entries are voided or purged accordingly. The existing VoidHandler in VisitWithQueueEntriesSaveHandler does not reliably fire when visitService.voidVisit() is called, so the AOP advice provides a reliable mechanism for both void and purge paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Purge test now actually calls visitService.purgeVisit() to verify the FK constraint issue is resolved end-to-end - Void test now isolates the advice behavior, proving the advice (not the VoidHandler) is what voids the queue entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a visit is deleted (voided or purged), associated queue entries were not being removed, leaving patients visible in the service queue despite their visit being gone.
JIRA: O3-5459
Root Cause
The existing
VisitWithQueueEntriesSaveHandlerimplementsVoidHandler<Visit>, but this handler does not reliably fire whenvisitService.voidVisit()is called. The handler only works through thesaveVisit()path. Additionally, there was no handling forpurgeVisit()at all.Changes
VisitWithQueueEntriesDeleteAdvice— an AOPMethodBeforeAdviceregistered onVisitServicethat intercepts:voidVisit(): voids all associated queue entries with the same void reasonpurgeVisit(): purges all associated queue entries before the visit is permanently deleted (preventing FK constraint violations)config.xmlvia the<advice>elementTesting
All 98 integration tests pass.