Add workitem queue FFI functions (add, update, delete)#2
Open
SPEDERER wants to merge 5 commits intoopeniap:mainfrom
Open
Add workitem queue FFI functions (add, update, delete)#2SPEDERER wants to merge 5 commits intoopeniap:mainfrom
SPEDERER wants to merge 5 commits intoopeniap:mainfrom
Conversation
Add FFI bindings for workitem queue CRUD operations: - add_workitem_queue (sync + async) - update_workitem_queue (sync + async) - delete_workitem_queue (sync + async) - Corresponding free functions for memory management Python bindings: - add_workitem_queue() - update_workitem_queue() - delete_workitem_queue() Includes test cases in python/test.py Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…perations (add, update, delete)
- Update AceWrapper to match proto Ace struct (id, deny, rights) - Add acl and acl_len fields to WorkItemQueueWrapper - Implement ACL conversion in wrap_workitem_queue and unwrap_workitem_queue - Add proper memory cleanup for ACL arrays in free_workitem_queue_wrapper - Update Python bindings with AceWrapper ctypes structure - Add acl parameter to add_workitem_queue and update_workitem_queue methods - Parse and return ACL in response dictionaries Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/clib/src/lib.rsadd_workitem_queue,update_workitem_queue, anddelete_workitem_queueinpython/openiap/main.pypython/test.pyChanges
Rust FFI Layer (
crates/clib/src/lib.rs)WorkItemQueueWrapperstruct with C-compatible layoutadd_workitem_queue/add_workitem_queue_async- Create new workitem queuesupdate_workitem_queue/update_workitem_queue_async- Update existing workitem queuesdelete_workitem_queue/delete_workitem_queue_async- Delete workitem queues with optional purgefree_*functions for memory managementPython Bindings (
python/openiap/main.py)add_workitem_queue()- Create workitem queue with configurable options (maxretries, retrydelay, initialdelay, etc.)update_workitem_queue()- Update workitem queue propertiesdelete_workitem_queue()- Delete workitem queue with optional purge flagTests (
python/test.py)Test plan
🤖 Generated with Claude Code