fix: avoid circular import of AuthzEnforcer#143
Conversation
|
Thanks for the pull request, @MaferMazu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
011f560 to
d5b13bf
Compare
|
Can we find the root problem of these circular imports? Going back to @BryanttV's solution would be simpler: #141 (comment) |
d5b13bf to
8469ed3
Compare
4357a80 to
2fab136
Compare
BryanttV
left a comment
There was a problem hiding this comment.
LGTM, thanks! @MaferMazu
Description
This PR solves #141; you can find how to reproduce the issue there.
How to test
Be able to run:
./manage lms load_policiesYou can also verify that withouth this change, the import of AuthzEnforcer fails.
eduNEXT#2
Extra details
We are checking circular imports with pylint, but it does it statically. And this problem occurred at runtime; for that reason, the tests were passing.
And, casually, in test_commands.py, we imported the api first, so there was no circular import.
Merge checklist:
Check off if complete or not applicable: