Skip to content

fix: avoid circular import of AuthzEnforcer#143

Merged
MaferMazu merged 3 commits intoopenedx:mainfrom
eduNEXT:mfmz/fix-circular-import
Nov 14, 2025
Merged

fix: avoid circular import of AuthzEnforcer#143
MaferMazu merged 3 commits intoopenedx:mainfrom
eduNEXT:mfmz/fix-circular-import

Conversation

@MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Nov 13, 2025

Description

This PR solves #141; you can find how to reproduce the issue there.

How to test

Be able to run: ./manage lms load_policies

You can also verify that withouth this change, the import of AuthzEnforcer fails.
eduNEXT#2

Extra details

We are checking circular imports with pylint, but it does it statically. And this problem occurred at runtime; for that reason, the tests were passing.
And, casually, in test_commands.py, we imported the api first, so there was no circular import.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 13, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @MaferMazu!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 13, 2025
@MaferMazu MaferMazu linked an issue Nov 13, 2025 that may be closed by this pull request
@MaferMazu MaferMazu force-pushed the mfmz/fix-circular-import branch 3 times, most recently from 011f560 to d5b13bf Compare November 13, 2025 01:48
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Nov 13, 2025

Can we find the root problem of these circular imports? Going back to @BryanttV's solution would be simpler: #141 (comment)

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Nov 13, 2025
@MaferMazu MaferMazu force-pushed the mfmz/fix-circular-import branch from d5b13bf to 8469ed3 Compare November 14, 2025 17:02
@MaferMazu MaferMazu force-pushed the mfmz/fix-circular-import branch from 4357a80 to 2fab136 Compare November 14, 2025 17:39
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! @MaferMazu

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MaferMazu MaferMazu changed the title fix: circular import problem fix: avoid circular import of AuthzEnforcer Nov 14, 2025
@MaferMazu MaferMazu merged commit fe1d9bc into openedx:main Nov 14, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: Fix circular import

5 participants