Properly detect submodule versions#7559
Merged
gregorydlogan merged 1 commit intoopencast:r/18.xfrom Apr 10, 2026
Merged
Conversation
…check this value once. This is important since in the case of the submodules we *do not want* the buildnumber to be the submodule's version. Instead we want to use the parent's version, and have the submodules propagate their own in submodule specific ways.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the version check in every single module, replacing it with a single parent check. This lets the submodules use the parent's version as their buildnumber, which is currently causing the version listing at the bottom of the admin UI to say
Opencast – built on unknownbecause the module hashes don't work.Note that we do not currently store the submodule hash in the database, so we have no way to know if the submodules have been modified. A future PR will add support for this, but likely will only land in
develop.This needs to go into
r/18.xsince otherwise the UI complains :)Related PRs:
opencast/admin-interface#1573
opencast/editor#1696
opencast/studio#1314
How to test this patch
Build Opencast and ensure that the admin UI does not say
built on unknownat the bottomYour pull request should…
close an accompanying issue if one existsinclude migration scripts and documentation, if appropriateinclude a release note if a feature, or supports a feature (ie, backend part of a frontend feature)