Skip to content

Use react-select for page size dropdown#1568

Open
Arnei wants to merge 2 commits intoopencast:developfrom
Arnei:a11y-page-size-select
Open

Use react-select for page size dropdown#1568
Arnei wants to merge 2 commits intoopencast:developfrom
Arnei:a11y-page-size-select

Conversation

@Arnei
Copy link
Copy Markdown
Member

@Arnei Arnei commented Apr 7, 2026

Originally #1530

Fixes #1215.

We are currently using our own custom styled dropdown thingy for the page size selector. This patch instead uses "Select" from react-select for the page size selector. The goal is to get the accessibility features of using a proper select component "for free", instead of having to painstakingly code our own. Apart from that, the page size selector should work as before.

How to test this

Can be tested as is. The page size selector is the element at the bottom right of the page.

@Arnei Arnei added type:enhancement New feature or request type:usability Improves the UX labels Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/admin-interface:pr-1568

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/admin-interface:pr-1568

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

This pull request is deployed at test.admin-interface.opencast.org/1568/2026-04-10_07-20-26/ .
It might take a few minutes for it to become available.

@geichelberger
Copy link
Copy Markdown
Contributor

Should we use a different border color? It doesn't fit the other colors. I think the border color should be #378dd4

grafik

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

We are currently using our own custom styled dropdown
thingy for the page size selector. This patch instead uses "Select"
from react-select for the page size selector. The goal is to get the
accessibility features of using a proper select component
"for free", instead of having to painstakingly code our own.
Apart from that, the page size selector should work as before.
@Arnei Arnei force-pushed the a11y-page-size-select branch from c66450d to 0400403 Compare April 9, 2026 08:59
@Arnei
Copy link
Copy Markdown
Member Author

Arnei commented Apr 9, 2026

The border color of what specific part of the select are you referring to? They look fine to me.

@geichelberger
Copy link
Copy Markdown
Contributor

This one:

grafik

height: 28,
width: 75,
borderRadius: 4,
borderColor: state.isFocused ? "#378dd4" : "hsl(0, 0%, 80%)",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

		"&:hover": {
				borderColor: state.isFocused ? "#378dd4" : "hsl(0, 0%, 80%)",
		},

Shouldn't it be like that?
But there is a box shadow with the wrong color, which is quite strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement New feature or request type:usability Improves the UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pagination Items per Page cannot be operated via keyboard

2 participants