-
Notifications
You must be signed in to change notification settings - Fork 40
Less queries #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
geichelberger
wants to merge
2
commits into
opencast:r/19.x
Choose a base branch
from
geichelberger:less-queries
base: r/19.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−44
Open
Less queries #1542
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { ReactNode, useEffect } from "react"; | ||
| import { ReactNode, useEffect, useRef } from "react"; | ||
| import { useTranslation } from "react-i18next"; | ||
| import TableFilters from "../shared/TableFilters"; | ||
| import Table, { TemplateMap } from "../shared/Table"; | ||
|
|
@@ -7,7 +7,7 @@ import { fetchFilters } from "../../slices/tableFilterSlice"; | |
| import { CreateType, NavBarLink } from "../NavBar"; | ||
| import { AppThunk, RootState, useAppDispatch, useAppSelector } from "../../store"; | ||
| import { resetTableProperties, Resource } from "../../slices/tableSlice"; | ||
| import { AsyncThunk } from "@reduxjs/toolkit"; | ||
| import { AsyncThunk, PayloadAction } from "@reduxjs/toolkit"; | ||
| import { ParseKeys } from "i18next"; | ||
| import { useLocation } from "react-router"; | ||
| import MainPage from "./MainPage"; | ||
|
|
@@ -40,37 +40,89 @@ const TablePage = ({ | |
| }) => { | ||
| const { t } = useTranslation(); | ||
| const dispatch = useAppDispatch(); | ||
| const currentLoadRequest = useRef<{ abort:() => void } | null>(null); | ||
| const latestLoadRequestId = useRef(0); | ||
| const allowLoadIntoTable = useRef(true); | ||
| const currentLoadSource = useRef<"auto" | "filters">(null); | ||
| const autoRefreshPaused = useRef(false); | ||
| const autoRefreshPauseTimeout = useRef<ReturnType<typeof setTimeout> | null>(null); | ||
|
|
||
| const location = useLocation(); | ||
|
|
||
| const numberOfRows = useAppSelector(state => getTotalResources(state)); | ||
|
|
||
| const pauseAutoRefresh = () => { | ||
| autoRefreshPaused.current = true; | ||
|
|
||
| if (autoRefreshPauseTimeout.current) { | ||
| clearTimeout(autoRefreshPauseTimeout.current); | ||
| } | ||
|
|
||
| autoRefreshPauseTimeout.current = setTimeout(() => { | ||
| autoRefreshPaused.current = false; | ||
| autoRefreshPauseTimeout.current = null; | ||
| }, 2000); | ||
| }; | ||
|
|
||
| const loadResource = async (source: "auto" | "filters" = "auto") => { | ||
| if (source === "filters") { | ||
| pauseAutoRefresh(); | ||
| } | ||
|
|
||
| if (source === "auto" && autoRefreshPaused.current) { | ||
| return; | ||
| } | ||
|
|
||
| if (source === "auto" && currentLoadSource.current === "filters") { | ||
| return; | ||
| } | ||
|
|
||
| const requestId = ++latestLoadRequestId.current; | ||
| currentLoadSource.current = source; | ||
|
|
||
| currentLoadRequest.current?.abort?.(); | ||
|
|
||
| const fetchRequest = dispatch(fetchResource()) as Promise<PayloadAction<any, string>> & { abort:() => void }; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can do without the type assertions here to make this a bit easier to read? |
||
| currentLoadRequest.current = fetchRequest; | ||
|
|
||
| const fetchResult = await fetchRequest as { meta?: { requestStatus?: string } }; | ||
|
|
||
| if (requestId === latestLoadRequestId.current) { | ||
| currentLoadSource.current = null; | ||
| } | ||
|
|
||
| if ( | ||
| allowLoadIntoTable.current | ||
| && requestId === latestLoadRequestId.current | ||
| && fetchResult?.meta?.requestStatus === "fulfilled" | ||
| ) { | ||
| dispatch(loadResourceIntoTable()); | ||
| } | ||
| }; | ||
|
|
||
| const loadResourceFromFilters = () => loadResource("filters"); | ||
|
|
||
| useEffect(() => { | ||
| // State variable for interrupting the load function | ||
| let allowLoadIntoTable = true; | ||
| allowLoadIntoTable.current = true; | ||
|
|
||
| // Clear table of previous data | ||
| dispatch(resetTableProperties()); | ||
|
|
||
| dispatch(fetchFilters(resource)); | ||
|
|
||
| // Load resource on mount | ||
| const loadResource = async () => { | ||
| // Fetching resources from server | ||
| await dispatch(fetchResource()); | ||
|
|
||
| // Load resources into table | ||
| if (allowLoadIntoTable) { | ||
| dispatch(loadResourceIntoTable()); | ||
| } | ||
| }; | ||
| loadResource(); | ||
| loadResource("auto"); | ||
|
|
||
| // Fetch resources every minute | ||
| const fetchResourceInterval = setInterval(loadResource, 5000); | ||
| const fetchResourceInterval = setInterval(() => loadResource("auto"), 5000); | ||
|
|
||
| return () => { | ||
| allowLoadIntoTable = false; | ||
| allowLoadIntoTable.current = false; | ||
| currentLoadRequest.current?.abort?.(); | ||
| if (autoRefreshPauseTimeout.current) { | ||
| clearTimeout(autoRefreshPauseTimeout.current); | ||
| autoRefreshPauseTimeout.current = null; | ||
| } | ||
| clearInterval(fetchResourceInterval); | ||
| }; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
|
|
@@ -91,8 +143,7 @@ const TablePage = ({ | |
|
|
||
| {/* Include filters component */} | ||
| <TableFilters | ||
| loadResource={fetchResource} | ||
| loadResourceIntoTable={loadResourceIntoTable} | ||
| loadResource={loadResourceFromFilters} | ||
| resource={resource} | ||
| /> | ||
| </div> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not set to
0instead of1?