Skip to content

Fix MPI pre-cell handling, node set resolution, and post_gid fallback#78

Merged
ilkilic merged 8 commits intomainfrom
mpi-precell-check
Apr 10, 2026
Merged

Fix MPI pre-cell handling, node set resolution, and post_gid fallback#78
ilkilic merged 8 commits intomainfrom
mpi-precell-check

Conversation

@ilkilic
Copy link
Copy Markdown
Collaborator

@ilkilic ilkilic commented Apr 10, 2026

This PR fixes three issues in circuit instantiation:

  • Fixes MPI pre-cell handling for connections when presynaptic populations are not locally instantiated on a rank.
  • Fixes composite multi-population node set resolution for alias node sets (e.g. node sets defined as lists of other node sets).
  • Restores standalone synapse creation compatibility by allowing post_gid to fall back to cell_id.id when not explicitly provided.

@ilkilic ilkilic self-assigned this Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 95.27559% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tests/test_circuit_simulation_mpi.py 95.23% 3 Missing ⚠️
...ab/circuit/circuit_access/sonata_circuit_access.py 87.50% 2 Missing ⚠️
bluecellulab/circuit_simulation.py 93.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
bluecellulab/synapse/synapse_types.py 83.02% <100.00%> (ø)
tests/test_circuit/test_circuit_access.py 100.00% <100.00%> (ø)
tests/test_synapse/test_synapse_factory.py 100.00% <100.00%> (ø)
bluecellulab/circuit_simulation.py 84.63% <93.33%> (+0.39%) ⬆️
...ab/circuit/circuit_access/sonata_circuit_access.py 95.81% <87.50%> (-0.76%) ⬇️
tests/test_circuit_simulation_mpi.py 97.43% <95.23%> (-1.05%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilkilic ilkilic changed the title Fix MPI pre-cell handling and composite node set resolution Fix MPI pre-cell handling, node set resolution, and post_gid fallback Apr 10, 2026
@ilkilic ilkilic merged commit c24e0f9 into main Apr 10, 2026
9 checks passed
@ilkilic ilkilic deleted the mpi-precell-check branch April 10, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants