Add button to reload an individual NM conn profile#40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on #36 (which restored functionality to the button to reload all NM conn profiles simultaneously) by adding a button to the advanced NetworkManager connection profile editor to reload only the connection profile displayed by the editor.
This functionality will also be needed for reloading the conn profile for a hotspot after changing that hotspot's password, so this PR is part of https://www.notion.so/Support-changing-the-Wi-Fi-hotspot-password-from-the-Machine-Admin-app-3224e612c78a809cbebcdb052a8545de?source=copy_link .
This PR also follows up on #36 by removing some dead code only needed if device-admin's server were launched with root permissions and without a sidecar; such a deployment configuration is unnecessary and less secure and not used in openUC2/os-rpi, so there's no need to keep around code paths specific to it.