Skip to content

Switch from yarn to pnpm #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanjli merged 1 commit into from
Mar 19, 2026
Merged

Switch from yarn to pnpm #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ clean: ## remove files created during build pipeline
install: ## go install tools
$(call print-target)
go install tool
cd web/app && corepack enable && pnpm install

.PHONY: generate
generate: ## go generate
Expand All @@ -28,7 +29,7 @@ generate: ## go generate
.PHONY: buildweb
buildweb: ## generate webapp build artifacts
$(call print-target)
cd web/app && yarn && yarn build
cd web/app && pnpm run build

.PHONY: vet
vet: ## go vet
Expand All @@ -39,12 +40,13 @@ vet: ## go vet
fix: ## go fix
$(call print-target)
go fix ./...
cd web/app && pnpm run lint:fix

.PHONY: fmt
fmt: ## go fmt
$(call print-target)
go tool golangci-lint fmt
cd web/app && yarn format
cd web/app && pnpm run format

.PHONY: spell
spell: ##misspell
Expand All @@ -55,7 +57,7 @@ spell: ##misspell
lint: ## golangci-lint
$(call print-target)
go tool golangci-lint run
cd web/app && yarn lint
cd web/app && pnpm run lint

.PHONY: test
test: ## go test with race detector and code covarage
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ environment variables (see below) to non-default values.

To install various backend development tools, run `make install`. You will need to have installed Go first.

Before you start the server for the first time, you'll need to generate the webapp build artifacts by running `make buildweb` (which requires you to have first installed [Node.js](https://nodejs.org/en/) and [Yarn Classic](https://classic.yarnpkg.com/lang/en/)). Then you can start the server by running `make run` with the appropriate environment variables (see below); or you can run `make runlive` so that your edits to template files will be reflected after you refresh the corresponding pages in your web browser. You will need to have installed golang first. Any time you modify the webapp files (in the web/app directory), you'll need to run `make buildweb` again to rebuild the bundled CSS and JS.
Before you start the server for the first time, you'll need to generate the webapp build artifacts by running `make buildweb` (which requires you to have first installed [Node.js](https://nodejs.org/en/) with [Corepack](https://github.com/nodejs/corepack)). Then you can start the server by running `make run` with the appropriate environment variables (see below); or you can run `make runlive` so that your edits to template files will be reflected after you refresh the corresponding pages in your web browser. You will need to have installed golang first. Any time you modify the webapp files (in the web/app directory), you'll need to run `make buildweb` again to rebuild the bundled CSS and JS.

### Building

Expand Down
1 change: 1 addition & 0 deletions web/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"lint": "prettier --check --write ./src/**/*.{js,html} --no-error-on-unmatched-pattern && eslint src/**/*.{js} --no-error-on-unmatched-pattern",
"lint:fix": "prettier --write ./src/**/*.{js,html} --no-error-on-unmatched-pattern && eslint --fix src/**/*.{js} --no-error-on-unmatched-pattern"
},
"packageManager": "pnpm@10.32.1+sha512.a706938f0e89ac1456b6563eab4edf1d1faf3368d1191fc5c59790e96dc918e4456ab2e67d613de1043d2e8c81f87303e6b40d4ffeca9df15ef1ad567348f2be",
"devDependencies": {
"@eslint/eslintrc": "^3.3.5",
"@eslint/js": "^10.0.1",
Expand Down
Loading
Loading