Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates UC2ConfigurationController to improve the UX around applying UC2 configurations by adding a pre-apply warning dialog, improving restart/disconnect messaging, and making restart-related error handling more tolerant of transient gateway/network failures.
Changes:
- Added an “Apply configuration?” warning dialog requiring explicit confirmation before applying a setup.
- Improved restart handling by treating certain transient HTTP statuses as expected during restarts and refining connection-status messaging/icons.
- Adjusted hook/callback dependencies to ensure state refreshes occur reliably after restarts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| @@ -235,7 +239,7 @@ const UC2ConfigurationController = () => { | |||
|
|
|||
| // Start checking after 5 seconds | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the user experience and robustness of the
UC2ConfigurationControllercomponent by improving error handling during configuration application, adding a user warning dialog, and clarifying connection status feedback. The changes aim to prevent accidental misconfiguration, provide clearer feedback during restarts, and ensure more reliable state updates.User interaction and feedback improvements:
Dialog) that appears before applying a configuration, informing users of potential risks and requiring explicit confirmation before proceeding. This helps prevent accidental misconfigurations that could make the device temporarily unreachable. [1] [2] [3] [4]Error handling and reliability:
isExpectedRestartHttpStatus) to better identify expected transient errors during restarts, ensuring appropriate user notifications and smoother restart monitoring. [1] [2] [3]Code cleanup:
Chipfrom MUI, for cleaner code.…handling