Improve diagram editor connection compatibility hints#182
Improve diagram editor connection compatibility hints#182ArizmendiWan wants to merge 6 commits intoopen-rmf:mainfrom
Conversation
Signed-off-by: ArizmendiWan <2311602492@qq.com>
ArizmendiWan
force-pushed
the
zhenwan-issue-172-connection-hints
branch
from
a7faafc to
10abb27
Compare
|
Thanks for this contribution! The UI hints shown in the video look very impressive and helpful! Just one high level thought before conducting a full code review: a |
aaronchongth
left a comment
aaronchongth
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I've just left some high level review comments for now. Will get back to you soon with more a more in-depth review
Signed-off-by: ArizmendiWan <2311602492@qq.com>
ArizmendiWan
force-pushed
the
zhenwan-issue-172-connection-hints
branch
from
ef7542e to
d10cd87
Compare
|
Thanks for your feedbacks! I have addressed the requested review changes:
demo_v01.movPlease let me know if there’s anything else you’d like me to adjust. |
aaronchongth
left a comment
aaronchongth
left a comment
There was a problem hiding this comment.
Thanks for the changes so far, I left a few comments.
Regarding the UI, the buttons should appear below the filter input, instead of on the right.
When there are no valid operations, the text lines up below the filter properly, the buttons should do that too in general
| const remappedId = addUniqueSuffix( | ||
| 'new_input', | ||
| nodeManager.nodes | ||
| .filter((n) => n.type === 'sectionInput') |
There was a problem hiding this comment.
There was a problem hiding this comment.
Updated to use the existing node helper
| const outputId = addUniqueSuffix( | ||
| 'new_output', | ||
| nodeManager.nodes | ||
| .filter((n) => n.type === 'sectionOutput') |
There was a problem hiding this comment.
There was a problem hiding this comment.
Updated to use the existing node helper
| const remappedId = addUniqueSuffix( | ||
| 'new_buffer', | ||
| nodeManager.nodes | ||
| .filter((n) => n.type === 'sectionBuffer') |
There was a problem hiding this comment.
There was a problem hiding this comment.
Updated to use the existing node helper
| </ButtonGroup> | ||
| {operations.length === 0 && ( | ||
| <Typography variant="body2" sx={{ px: 1.5, py: 1.5, width: 260 }}> | ||
| No compatible operations are available for this output yet. |
There was a problem hiding this comment.
This is also prompted when filtered via text with no results instead of handling an output, either
- identify which case it is, and provide proper explanations, or
- use more generic wording to cover both cases
I personally would like it to be the first case, since it is more verbose and explanatory to the user
There was a problem hiding this comment.
Updated the empty-state messaging to distinguish filter-empty from compatibility-empty.
Update the add-operation UI and connection hints for compatible previous and next operations, and keep the supporting drag-direction logic aligned with that flow. Signed-off-by: ArizmendiWan <2311602492@qq.com>
Signed-off-by: ArizmendiWan <2311602492@qq.com>
|
Thanks for the review! I have addressed the remaining review comments:
demo_v02.mov |
Signed-off-by: ArizmendiWan <2311602492@qq.com>
|
I also updated the compatibility hint functionality. Right now it also checks if a handle is already full. If one handle is full, no compatibility will be shown and the hint panel will show corresponding messages. demo_v03.mov |
3 participants
This PR is an initial implementation for #172. It improves drag-time connection feedback and adds a compatibility-aware next-operation flow in the diagram editor.
Current changes include:
demo.mov
This PR also includes a small incidental frontend sync fix for a stale generated type/schema reference that was needed to keep the frontend building cleanly.
GenAI Use
Generated-by: Codex Version 26.309.31024 (962) and Claude Code v2.1.76.