Skip to content

More LR Driver#445

Open
jlpoltrack wants to merge 4 commits intoolliw42:mainfrom
jlpoltrack:More-LR-Driver
Open

More LR Driver#445
jlpoltrack wants to merge 4 commits intoolliw42:mainfrom
jlpoltrack:More-LR-Driver

Conversation

@jlpoltrack
Copy link
Copy Markdown
Collaborator

  • Switches IRQ to be set by define and not hardcoded to DIO 7
  • Error if this define is not set
  • Adds method for setting up DIOs
  • Power calc to allow for custom levels instead of fixed gain

@olliw42
Copy link
Copy Markdown
Owner

olliw42 commented Apr 8, 2026

this I was wondering also about with the previous PR on SX_TCXO_VOLTAGE
this way requires including some sx driver .h files in the hal file, right?
If so, I'm not sure I like that approach. I guess I would prefer providing more detailed defines, such as SX_TCXO_VOLTAGE_3P3V.
Dito e.g. SX_IRQ_DIO_7, plus what you now need

@olliw42
Copy link
Copy Markdown
Owner

olliw42 commented Apr 8, 2026

fyi, have pushed the announced tidying PR, which also changed to SX_USE_TCXO_VOLTAGE
and created the conflicts
sorry for that

@jlpoltrack
Copy link
Copy Markdown
Collaborator Author

this way requires including some sx driver .h files in the hal file, right?

At least for PlatformIO Targets, no additional includes are needed. Just use enums from the library files via define, example:

image

@olliw42
Copy link
Copy Markdown
Owner

olliw42 commented Apr 8, 2026

pl try then also for STM32 ... following the include path I'm almost sure it won't work
(how could it, you need to include the hal before the sx driver as the hal sets defines for the sx driver ... don't underatand how it can work for vsc)

@jlpoltrack
Copy link
Copy Markdown
Collaborator Author

pl try then also for STM32 ... following the include path I'm almost sure it won't work

You're probably right, but I don't have any STM32 targets in my branch, so I can't test.

don't underatand how it can work for vsc

I think since we include the radio submodule like so (line 501):
image

@olliw42
Copy link
Copy Markdown
Owner

olliw42 commented Apr 9, 2026

ohhkkaayy ... it only includes the module lib drivers ...

so, I'm almost sure, won't work on stm32 ...

@jlpoltrack
Copy link
Copy Markdown
Collaborator Author

so, I'm almost sure, won't work on stm32 ...

Using numbers instead of the enums is an option too - this is done on LR1121 for the rfsw stuff.

@olliw42
Copy link
Copy Markdown
Owner

olliw42 commented Apr 9, 2026

Using numbers instead of the enums is an option too - this is done on LR1121 for the rfsw stuff.

was thinking this too, would work well for the DIO no ... but I guess would be ugly for the configs ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants