Open
Conversation
pgom
force-pushed
the
feature/add-authorize
branch
4 times, most recently
from
d8fabcc to
36bab0b
Compare
src/providers/oauth-provider.js
Outdated
pgom
force-pushed
the
feature/add-authorize
branch
from
36bab0b to
eaa5f24
Compare
Member
|
@pgom could you please provide a description? |
|
|
||
| authorize(clientId, scope, state) { | ||
| // Check if `clientId` is defined. | ||
| if (!clientId) { |
Member
There was a problem hiding this comment.
Update error message to:
throw new Error('Missing parameter: clientId.');
pgom
force-pushed
the
feature/add-authorize
branch
from
eaa5f24 to
36d10ce
Compare
|
What is left for this to be merged? |
|
+1 for this. |
|
+1 as well, what is left to be changed here for this to get merged? |
Member
|
@pgom Let's rebase this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.