Skip to content

Adding linkcheck (and check for other build problems)#304

Open
bsipocz wants to merge 11 commits intonumpy:mainfrom
bsipocz:MAINT_adding_linkcheck
Open

Adding linkcheck (and check for other build problems)#304
bsipocz wants to merge 11 commits intonumpy:mainfrom
bsipocz:MAINT_adding_linkcheck

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 7, 2026

This will close #156

I expect seeing broken links here which should be fixed.

@bsipocz bsipocz added infrastructure Issues relevant to infrasructure, rather than content maintenance labels Feb 7, 2026
Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks @bsipocz ! This is a definite improvement

For whatever reason the CI run borked the first time through - when I re-ran it it failed as expected (including the errors in the log). I took the liberty of pushing up fixes for those errors. Most of them were either removing or replacing dead links (see individual commits for comments).

The last one is the latex rendering error which has been present for a while. I finally went about searching how to fix it :) - the build errors are gone and the rendering now seems to be fixed (scroll down a bit from that anchor to see the rendered TeX - compare with what's currently deployed).

Circleci in particular seems a bit flaky (there have been a couple timeouts related to this PR) - but there's no evidence it's related to the --strict. My vote would be to put this in and simply keep an eye on circleci to see if we continue getting extraneous timeouts.

Thanks again @bsipocz ! I approve this but will let someone else merge so folks have a chance to look the changes I pushed up too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues relevant to infrasructure, rather than content maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: add a linkchecker job

2 participants