Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3830 +/- ##
==========================================
+ Coverage 26.02% 26.11% +0.08%
==========================================
Files 675 675
Lines 43760 43885 +125
==========================================
+ Hits 11388 11459 +71
- Misses 31315 31361 +46
- Partials 1057 1065 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
initial-placement
branch
7 times, most recently
from
96f2c39 to
a4553c1
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
cthulhu-rider
force-pushed
the
initial-placement
branch
2 times, most recently
from
f87d1da to
e605908
Compare
roman-khimov
reviewed
Mar 5, 2026
carpawell
reviewed
Mar 6, 2026
| }) | ||
| } | ||
|
|
||
| initial := t.initialPolicy != nil && (t.sessionSigner != nil || !t.localOnly) |
Member
There was a problem hiding this comment.
why sessionSigner is special for us?
Contributor
Author
There was a problem hiding this comment.
if it is set, this is definitely the initial placement
cthulhu-rider
force-pushed
the
initial-placement
branch
3 times, most recently
from
0722ae9 to
2802bc0
Compare
Member
roman-khimov
left a comment
roman-khimov
left a comment
There was a problem hiding this comment.
Changelog. Looks better overall.
| return p | ||
| } | ||
|
|
||
| func (p *PutInitPrm) WithCopiesNumber(cn uint32) *PutInitPrm { |
Member
There was a problem hiding this comment.
Should be documented as unsupported in changelog.
This refactoring will help to support initial placement rules (nspcc-dev/neofs-api#352) which will not apply to system objects. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Such requests are specific, so it's clearer to handle them in a separate branch. Also, avoid undefined field values. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
nspcc-dev/neofs-sdk-go@e6342b6...b703a48. IR performs verification of initial rules against the main ones. CLI supports initial rules specified in JSON file only for now. SN allows such policies to be created, but is not yet able to serve them. This will be supported in future updates. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
IR doesn't currently support such policies, but it's very easy to support them in advance. It will also be useful for initial policies. Refs #3592. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Follow nspcc-dev/neofs-api#382. It is being overwhelmed by initial policy. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Refactoring which will be used to support initial policies. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
initial-placement
branch
from
2802bc0 to
ad1bae4
Compare
Follow nspcc-dev/neofs-api#352. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
initial-placement
branch
from
ad1bae4 to
de597a6
Compare
Contributor
Author
|
seems like REST GW integration tests fail due to serialization divergence after nspcc-dev/neofs-sdk-go@32480e3 fix. Updating the SDK in GW should resolve the situation |
Member
|
REST is to be updated once node is released, yes. Refs. nspcc-dev/neofs-rest-gw#369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.