refactor: use binary format strings in logger calls#377
Merged
Taure merged 2 commits intonovaframework:masterfrom Mar 19, 2026
Merged
refactor: use binary format strings in logger calls#377Taure merged 2 commits intonovaframework:masterfrom
Taure merged 2 commits intonovaframework:masterfrom
Conversation
Replace list string literals ("...") with binary (<<"...">>) in all
logger/LOG_* macro calls for consistent log output.
burbas
requested changes
Mar 19, 2026
Contributor
burbas
left a comment
burbas
left a comment
There was a problem hiding this comment.
Looks alright - just remove the line stated below and I'm happy :)
|
|
||
| format_arity([], Acc) -> | ||
| logger:warning("Acc: ~p~n", [Acc]), | ||
| logger:warning(<<"Acc: ~p~n">>, [Acc]), |
burbas
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"..."format strings with binary<<"...">>in allloggerand?LOG_*macro callsnova.hrl,nova_router.erl,nova_error_controller.erl,nova_plugin_manager.erlTest plan
rebar3 compilepassesrebar3 eunit— all 347 tests pass