Replace postman-request with axios#278
Merged
aviadhahami merged 3 commits intomasterfrom Mar 10, 2026
Merged
Conversation
- Remove postman-request dependency - Remove @types/request devDependency - Add axios as HTTP client - Update src/index.js with axios-based request wrapper that maintains the same response interface (statusCode, body, request.path) - Update index.d.ts to use AxiosRequestConfig instead of request.CoreOptions Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
…tatus Co-authored-by: aviadhahami <7353632+aviadhahami@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Upgrade postman-request package to modern alternative
Replace postman-request with axios
Mar 10, 2026
aviadhahami
approved these changes
Mar 10, 2026
aviadhahami
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postman-requestis a deprecated fork of the unmaintainedrequestlibrary. Replace withaxios.Changes
src/index.js: Swappostman-request+util.promisifyfor an axios instance. Response shape (statusCode,body,request.path) is preserved sohandleVaultResponseand all callers are unchanged.index.d.ts:request.CoreOptions→AxiosRequestConfigpackage.json: Droppostman-request,@types/request; addaxios@^1.13.6Notes
config['request-promise']dependency injection still works — existing consumers passing a custom request implementation are unaffected.VAULT_SKIP_VERIFYmapped tohttps.Agent({ rejectUnauthorized: false })(equivalent to priorstrictSSL: false).validateStatus: () => truereplicatessimple: false— lets vault response handler deal with non-2xx codes.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh pr ready 278(http block)/usr/bin/gh gh auth status(http block)/usr/bin/gh gh api graphql -f query= mutation { markPullRequestReadyForReview(input: {pullRequestId: ""}) { pullRequest { isDraft } } }(http block)https://api.github.com/repos/nodevault/node-vault/pulls/278/usr/bin/curl curl -s -X PATCH -H Authorization: ****** -H Accept: application/vnd.github+json REDACTED -d {"draft": false}(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.