fix(header): enable header host to fix mtls for specific case, fix #4034#4879
Open
sibelius wants to merge 1 commit intonodejs:mainfrom
Open
fix(header): enable header host to fix mtls for specific case, fix #4034#4879sibelius wants to merge 1 commit intonodejs:mainfrom
sibelius wants to merge 1 commit intonodejs:mainfrom
Conversation
mcollina
requested changes
Mar 11, 2026
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I don't think we should go against the spec. What does Deno do on this regard?
This is unfortunate :(
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4879 +/- ##
==========================================
- Coverage 93.01% 93.01% -0.01%
==========================================
Files 112 112
Lines 35287 35291 +4
==========================================
+ Hits 32823 32825 +2
- Misses 2464 2466 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KhafraDev
requested changes
Mar 11, 2026
Member
KhafraDev
left a comment
KhafraDev
left a comment
There was a problem hiding this comment.
I agree with @mcollina, you can use the dispatcher api we provide to handle this https://gist.github.com/KhafraDev/af69d9652e93f4e28e139853c818f46b
Author
|
can you provide an example to keep Host header ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
This issue #4034
Rationale
node-fetch behavior enables to override Host request header, using undici.request also works, but undici.fetch breaks
Changes
when passing Header Host it will go along the request instead of host:port
Features
Bug Fixes
Breaking Changes and Deprecations
Status