feat(ui-components): add collapsible sidebar (#8595)#8610
Open
omerbakr wants to merge 2 commits intonodejs:mainfrom
Open
feat(ui-components): add collapsible sidebar (#8595)#8610omerbakr wants to merge 2 commits intonodejs:mainfrom
omerbakr wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: omerbakr <y.omerbakir@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
21
to
26
| &[data-collapsed='true'] { | ||
| transform: translateX(-100%); | ||
|
|
||
| .mobileSelect { | ||
| @apply ml:hidden | ||
| flex | ||
| w-full; | ||
| .content { | ||
| @apply invisible; | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves #8595 by introducing a collapsible sidebar functionality to the ui-components package.
Only the left navigation sidebar is made collapsible. The right sidebar (Table of Contents) is kept static as it provides essential in-page navigation and is less overwhelming than the main navigation tree. This maintains a focused reading experience while keeping the page structure balanced.