doc: use npm-published version of doc-kit#62139
doc: use npm-published version of doc-kit#62139avivkeller wants to merge 2 commits intonodejs:mainfrom
Conversation
|
Review requested:
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the doc-kit dependency from a GitHub archive tarball under the @nodejs scope to an npm-published package under the @node-core scope (@node-core/doc-kit@^1.0.0). This simplifies dependency management by using standard npm versioning instead of pinning to specific Git commit SHAs, and removes the custom update tooling that was only needed for the tarball-based approach.
Changes:
- Replaced
@nodejs/doc-kit(GitHub tarball) with@node-core/doc-kit@^1.0.0(npm registry) inpackage.json,Makefile, andvcbuild.bat - Removed the custom updater script (
update-doc.sh) and commit-fetching utility (get-latest-commit.mjs) that are no longer needed with npm-based versioning - Removed the
doc-kitentry from the CI auto-update workflow (.github/workflows/tools.yml) since npm's standardnpm updatecan handle updates via Dependabot or Renovate
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tools/doc/package.json |
Changed dependency from @nodejs/doc-kit (tarball URL) to @node-core/doc-kit@^1.0.0 |
Makefile |
Updated DOC_KIT path from @nodejs/doc-kit to @node-core/doc-kit |
vcbuild.bat |
Updated doc_kit_exe path from @nodejs/doc-kit to @node-core/doc-kit |
.github/workflows/tools.yml |
Removed the doc-kit auto-update CI matrix entry |
tools/dep_updaters/update-doc.sh |
Deleted — no longer needed with npm-based dependency |
tools/doc/get-latest-commit.mjs |
Deleted — no longer needed with npm-based dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62139 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 676 676
Lines 206481 206543 +62
Branches 39544 39545 +1
=======================================
+ Hits 185121 185178 +57
+ Misses 13492 13486 -6
- Partials 7868 7879 +11 🚀 New features to boost your workflow:
|
|
Looks like there might be an npm bug |
Closes #62050
cc @nodejs/web-infra