test_runner: fix wrong signal exit codes#62039
Open
edilson258 wants to merge 2 commits intonodejs:mainfrom
Open
test_runner: fix wrong signal exit codes#62039edilson258 wants to merge 2 commits intonodejs:mainfrom
edilson258 wants to merge 2 commits intonodejs:mainfrom
Conversation
The test runner was exiting with a generic error code when interrupted by signals such as SIGINT, instead of using the standard signal-based exit codes. This change ensures the runner returns the correct signal exit code (e.g., 130 for SIGINT) rather than 1. Fixes: nodejs#62037
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
atlowChemi
reviewed
Mar 5, 2026
lib/internal/test_runner/harness.js
Outdated
Comment on lines
+288
to
+289
| process.removeListener('SIGINT', () => terminationHandler(kSigInt)); | ||
| process.removeListener('SIGTERM', () => terminationHandler(kSigTerm)); |
Member
There was a problem hiding this comment.
This wouldn't work as it is a different function than the the attached listener?
Author
There was a problem hiding this comment.
Indeed and i think we can fix by creating a handler for each signal and use the same on signal attach and removal
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62039 +/- ##
==========================================
- Coverage 89.73% 89.59% -0.14%
==========================================
Files 676 674 -2
Lines 206069 205463 -606
Branches 39517 39401 -116
==========================================
- Hits 184909 184083 -826
- Misses 13310 13586 +276
+ Partials 7850 7794 -56
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test runner was exiting with a generic error code when interrupted by signals such as SIGINT, instead of using the standard signal-based exit codes.
This change ensures the runner returns the correct signal exit code (e.g., 130 for SIGINT) rather than 1.
Fixes: #62037