Skip to content

path: add escapeGlob and unescapeGlob#61269

Open
Xstoudi wants to merge 10 commits intonodejs:mainfrom
Xstoudi:feat/glob-escape
Open

path: add escapeGlob and unescapeGlob#61269
Xstoudi wants to merge 10 commits intonodejs:mainfrom
Xstoudi:feat/glob-escape

Conversation

@Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Jan 4, 2026

path: add escapeGlob and unescapeGlob

Expose minimatch escaping and unescaping capabilities on path module.

Fixes: #61258

This is an implem proposal fix #61258 using minimatch that is already-vendored. Also feel free to -1 the change if you think it doesn't have its place there.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/path

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels Jan 4, 2026
@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (ce2ec3d) to head (908aa69).
⚠️ Report is 480 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61269      +/-   ##
==========================================
+ Coverage   88.54%   89.59%   +1.04%     
==========================================
  Files         704      674      -30     
  Lines      208734   205504    -3230     
  Branches    40271    39401     -870     
==========================================
- Hits       184823   184118     -705     
+ Misses      15932    13596    -2336     
+ Partials     7979     7790     -189     
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.69% <100.00%> (+0.31%) ⬆️
lib/path.js 97.51% <100.00%> (+0.02%) ⬆️

... and 259 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added semver-minor PRs that contain new features and should be released in the next minor version. notable-change PRs with changes that should be highlighted in changelogs. labels Jan 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @avivkeller.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@Xstoudi
Copy link
Contributor Author

Xstoudi commented Feb 24, 2026

Hey, no interest?

@nodejs/path

@targos
Copy link
Member

targos commented Feb 25, 2026

@nodejs/path @nodejs/fs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. path Issues and PRs related to the path subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

path.escapeGlob

5 participants