fix: allow global package manager commands in projects with different packageManager#781
Open
EurFelux wants to merge 3 commits intonodejs:mainfrom
Open
fix: allow global package manager commands in projects with different packageManager#781EurFelux wants to merge 3 commits intonodejs:mainfrom
EurFelux wants to merge 3 commits intonodejs:mainfrom
Conversation
… packageManager Global operations (e.g., `npm install -g`, `pnpm add -g`, `yarn global add`) now bypass the project-level `packageManager` field check, since they operate outside of the project scope. Fixes nodejs#690 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
EurFelux
force-pushed
the
fix/global-commands-transparent
branch
from
80923a6 to
2c0acf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm install -g,pnpm add -g,yarn global add) now bypass the project-levelpackageManagerfield checkChanges
Added
isGlobalCommand()function insources/Engine.tsthat detects:-gor--globalflagglobal(note:yarn globalis only available in Yarn 1.x; if a newer version is used, Yarn itself will report an appropriate error)Test plan
npm install -gin yarn/pnpm projectspnpm add -gin yarn/npm projectsyarn global addin npm/pnpm projectsFixes #690
🤖 Generated with Claude Code