Skip to content

[Fix] Serialization / deserialization of enter factor...#656

Open
kiplingw wants to merge 2 commits intonmslib:developfrom
kiplingw:kip-serialize-ef
Open

[Fix] Serialization / deserialization of enter factor...#656
kiplingw wants to merge 2 commits intonmslib:developfrom
kiplingw:kip-serialize-ef

Conversation

@kiplingw
Copy link
Copy Markdown

Serialize and deserialize the user's enter factor parameter.

@kiplingw kiplingw changed the title Serialize / deserialize enter factor... Fix serialization / deserialization of enter factor... Mar 23, 2026
@kiplingw kiplingw changed the title Fix serialization / deserialization of enter factor... [Fix] serialization / deserialization of enter factor... Mar 23, 2026
@kiplingw kiplingw changed the title [Fix] serialization / deserialization of enter factor... [Fix] Serialization / deserialization of enter factor... Mar 23, 2026
@yurymalkov
Copy link
Copy Markdown
Member

That would break the compatibility between saves done with different versions.

@kiplingw
Copy link
Copy Markdown
Author

True. One way to fix that, albeit not retroactively, is to write out a binary version and check it when reading back. Thoughts?

@yurymalkov
Copy link
Copy Markdown
Member

I think if the change is made it needs to be backwards compatible (e.g. an old checkpoint without version would still be loaded).

@kiplingw
Copy link
Copy Markdown
Author

It's difficult to reliably determine older data since the first data written out is a size_t which could have a value of anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants