fix(checkhealth): check minor and patch opencode version#217
Merged
nickjvandyke merged 1 commit intonickjvandyke:mainfrom Mar 29, 2026
Merged
fix(checkhealth): check minor and patch opencode version#217nickjvandyke merged 1 commit intonickjvandyke:mainfrom
nickjvandyke merged 1 commit intonickjvandyke:mainfrom
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's a minor logic error (pun intended!) in the
:checkhealthlogic when comparing the opencode version. When the minor version is larger than the latest tested version, the patched version check is still performed. So, the following cases trigger warning. (see screenshots below):Related Issue(s)
It's probably not worth creating an issue just for this lol.
Screenshots/Videos
Before
After