fix(excludedfiles): inherit directory-specific excludes from parent directories and global exclusion list #9338
+218
−200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsding
force-pushed
the
bugfix/8713/inherit-excludes-from-parent-folders
branch
2 times, most recently
from
f4a03c1 to
44c1de0
Compare
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
…and global exclusion list Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
…andling Apparently this was supposed to be used for excluding placeholder files from earlier versions, however the entry in the ignore list that used this special syntax was removed in 4e3f2f7. As this feature seems rather unusual and unknown, might as well get rid of it to improve maintenance... Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
The tool tip was wrong anyway -- system entries could be modified for a long time already. I would rather figure out a nicer way to display why a certain rule appears in the list at a glance Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
…al + folder-specific settings Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
also log a message in case it failed Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
force-pushed
the
bugfix/8713/inherit-excludes-from-parent-folders
branch
from
44c1de0 to
274310f
Compare
|
|
Artifact containing the AppImage: nextcloud-appimage-pr-9338.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it was intentional to not consider the global exclusion list at all.
The #6404 feature request described that the folder-specific exclude dialogue should include the following text in the description:
related issues: #8713, #1636
To do:
!.gitkeep), mentioned in Add option to make exceptions to the exclusion list #5456, Overriding sync-exclude.lst in subfolder #5331