Skip to content

fix: make property labels accessible#5086

Open
GVodyanov wants to merge 1 commit intomainfrom
fix/label-accessibility
Open

fix: make property labels accessible#5086
GVodyanov wants to merge 1 commit intomainfrom
fix/label-accessibility

Conversation

@GVodyanov
Copy link
Contributor

@GVodyanov GVodyanov commented Feb 8, 2026

Fix #5048

Final result:
Screenshot From 2026-02-17 11-48-53
Screenshot From 2026-02-17 11-48-36

Changes:

  • Read only mode: gray label + p tags for text
  • Edit mode: NcInputField with native label, aligned NcSelect

Getting NcSelect to be the same height and aligned with the input field took some nasty custom CSS seeing as one is 34px and the other 30px, but I'm hoping this will eventually be fixed by nextcloud vue

@GVodyanov GVodyanov self-assigned this Feb 8, 2026
@GVodyanov GVodyanov added the 2. developing Work in progress label Feb 8, 2026
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Properties/PropertyText.vue 0.00% 6 Missing ⚠️
src/components/Properties/PropertyMultipleText.vue 0.00% 4 Missing ⚠️
src/components/Properties/PropertyDateTime.vue 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@GVodyanov
Copy link
Contributor Author

image

@GVodyanov
Copy link
Contributor Author

image

@GVodyanov GVodyanov force-pushed the fix/label-accessibility branch from 483497e to 7fcdb0d Compare February 16, 2026 16:04
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>

# Conflicts:
#	src/components/Properties/PropertyMultipleText.vue
@GVodyanov GVodyanov force-pushed the fix/label-accessibility branch from 7fcdb0d to 3827d8a Compare February 17, 2026 10:49
@GVodyanov GVodyanov marked this pull request as ready for review February 17, 2026 10:56
@GVodyanov GVodyanov requested a review from hamza221 as a code owner February 17, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing accessible labels for contact detail properties

2 participants