Fix: Hide *Delete* action for read-only address books#3388
Draft
Fix: Hide *Delete* action for read-only address books#3388
Conversation
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
hamza221
added
bug
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3388 +/- ##
==========================================
- Coverage 1.82% 0.00% -1.83%
Complexity 272 272
==========================================
Files 112 25 -87
Lines 6075 824 -5251
Branches 1445 0 -1445
==========================================
- Hits 111 0 -111
+ Misses 5849 824 -5025
+ Partials 115 0 -115 ☔ View full report in Codecov by Sentry. |
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
ABs can be shared read-only too. Then the collection should be deletable to allow unsharing.
We have to check if the AB is not shared but ro
hamza221
added
2. developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3383