Open
Conversation
mejo-
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mejo-
force-pushed
the
feat/event_reference_provider
branch
2 times, most recently
from
fdd5263 to
7856804
Compare
Fixes: #7104 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
feat/event_reference_provider
branch
from
7856804 to
ae2ecc3
Compare
mejo-
changed the title
tcitworld
requested changes
Mar 9, 2026
| private readonly IL10N $l10n, | ||
| private readonly IURLGenerator $urlGenerator, | ||
| private readonly IManager $calendarManager, | ||
| private CalDavBackend $calDavBackend, |
Member
There was a problem hiding this comment.
This should be made backend agnostic, and use OCP\ICalendar\IManager::getCalendarsForPrincipal in the getCalendar method, and OCP\Calendar\ICalendar\search in the getEventData method.
GVodyanov
reviewed
Mar 9, 2026
| <style lang="scss" scoped> | ||
| .event { | ||
| width: 100%; | ||
| padding-inline: 12px; |
Contributor
There was a problem hiding this comment.
Suggested change
| padding-inline: 12px; | |
| padding-inline: calc(var(--default-grid-baseline) * 3); |
GVodyanov
reviewed
Mar 9, 2026
Contributor
GVodyanov
left a comment
GVodyanov
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Please use our CSS variables instead of custom values for padding/margin/gap/etc.
You can check them out here https://docs.nextcloud.com/server/latest/developer_manual/html_css_design/css.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7104
Screenshot