fix: adding circles to events (#6023)#8008
Draft
MrAn0nym wants to merge 1 commit intonextcloud:mainfrom
Draft
Conversation
Signed-off-by: MrAn0nym <63542658+MrAn0nym@users.noreply.github.com>
Author
|
Didn't manage to look into how one would write tests yet and I believe |
Contributor
|
Hi @MrAn0nym Thank you for the PR. FYI, you might want to wait a couple weeks for this, as there are some pending changes that will be applied to the contacts controller which might effect your work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContactController::getCircleMembers is used to fetch all members of a circle, when adding that circle to an event.
Currently the function assumes members to be a nextcloud user:
calendar/lib/Controller/ContactController.php
Lines 227 to 229 in 04e8e49
This results in empty return values, which in turn causes an error and results in no member of the circle being added
calendar/lib/Controller/ContactController.php
Lines 231 to 233 in 0a0dc23
The PR changes the code to handle all types separately. Whilst this is not perfect and problems like federation or auto-updating memberlists are not solved by this it at least provides a short term fix for #6023 #6485 and one aspect of nextcloud/circles#1690 if I'm not mistaken.