feat: Show provider information in the UI (#408)#483
feat: Show provider information in the UI (#408)#483zainabnaseer1164 wants to merge 5 commits intonextcloud:mainfrom
Conversation
julien-nc
left a comment
There was a problem hiding this comment.
Hi! Thanks for the PR!
- Could you explain a bit more what you did?
- Could you provide a screenshot (useful to get an idea of what should be checked/tested)?
- Could you sign your commits? You can set a global GPG key for git (see the
GPG Introductionsection of https://git-scm.com/book/en/v2/Git-Tools-Signing-Your-Work) and then follow the instructions of the failing DCO GitHub action) - Could you generate the OpenAPI specs? (the openapi composer script does that)
- Could you move the new provider info in a place where the layout is not affected? Like next to the task type title? Right now it takes a lot of vertical space.
- There's something wrong with some characters, can you check that?
Feel free to ask questions if something I said was not clear.
lib/Service/AssistantService.php
Outdated
| 'optionalInputShapeEnumValues' => [], | ||
| 'optionalInputShapeDefaults' => [], | ||
| 'optionalOutputShape' => [], | ||
| 'optionalOutputShapeEnumValues' => [], |
There was a problem hiding this comment.
Is that fixing something else?
There was a problem hiding this comment.
It was added only to keep the chatty-llm task type in line with other task types that already have optionalOutputShapeEnumValues. It wasn’t fixing a bug or part of the provider-info feature. The current branch doesn’t add it; only preferredProviderName is added there.
9f16d8c to
70e19d7
Compare
- Compute preferred provider per task type in AssistantService - Add preferredProviderName to task type API response - Display provider name next to task type title in assistant form Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com> Made-with: Cursor Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com>
- Add preferredProviderName (string|null) to TaskProcessingTaskType schema - Matches API response for issue nextcloud#408 Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com> Made-with: Cursor Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com>
… load - TaskTypeSelect: show 'TaskName · ProviderName' in dropdown and tooltip - ContextChatInputForm: default contextChatIndexingComplete to false for standalone page - AssistantTextProcessingForm: remove extra blank line (lint) Refs: nextcloud#408 Made-with: Cursor Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com>
53d717b to
52fb038
Compare
Could you explain a bit more what you did? Could you provide a screenshot? Could you sign your commits? Could you generate the OpenAPI specs? Could you move the new provider info next to the task type title? There’s something wrong with some characters – can you check that? |
julien-nc
left a comment
There was a problem hiding this comment.
Thank you for the adjustments!
Openapi.json already includes preferredProviderName in this PR.
But the OpenAPI CI action is still failing because the specs were not generated again so they are out of date.
UI shows it next to the task type title and in the dropdown as “TaskName · ProviderName”.
I think adding the provider name in the dropdown is a bit too much. It is enough to have it in the form title. Wdyt?
I’ll fix display so apostrophes (e.g. “OpenAI’s”) show correctly instead of wrong one.
I can see it's displayed correctly now, did you fix it already?
So I will do it once I get approval from your side.
Sure if there is still a visual issue, you have my approval to fix it.
| <EditableTextField :initial-text="selectedTaskType.name ?? ''" /> | ||
| <span v-if="selectedTaskType.preferredProviderName" | ||
| class="session-area__top-bar__provider"> | ||
| {{ t('assistant', 'Provider:') }} {{ selectedTaskType.preferredProviderName }} |
There was a problem hiding this comment.
| {{ t('assistant', 'Provider:') }} {{ selectedTaskType.preferredProviderName }} | |
| {{ t('assistant', 'Provider: {name}', { name: selectedTaskType.preferredProviderName }) }} |
Better for RTL languages.
Run composer run openapi so committed spec matches CI generator. Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com> Made-with: Cursor
Per review: provider name only next to task type title, not in dropdown. Signed-off-by: zainabnaseer1164 <zainab.naseer1164@gmail.com> Made-with: Cursor
@julien-nc above comments have been tackled along with passing all pending GitHub test. |



Shows which AI provider will process each task type in the Assistant UI, so users know which provider handles their request.