Skip to content

fix(metric): suppress internal opentelemetry logging unless trace verbosity #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tronghn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metric): suppress internal opentelemetry logging unless trace verbosity #694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/application/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func Run(ctx context.Context, w io.Writer) error {
autoComplete := slices.Contains(os.Args[1:], "__complete")

if !autoComplete {
flushMetrics := metric.Initialize()
flushMetrics := metric.Initialize(f.IsTrace())
defer func() {
if err := recover(); err != nil {
handlePanic(err)
Expand Down
8 changes: 7 additions & 1 deletion internal/metric/otel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"os"
"time"

"github.com/go-logr/logr"
"github.com/nais/cli/internal/version"
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp"
Expand All @@ -22,7 +23,7 @@ const (

var initialized = false

func Initialize() func(verbose bool) {
func Initialize(verbose bool) func(verbose bool) {
if os.Getenv("DO_NOT_TRACK") == "1" || initialized {
return func(verbose bool) {
if verbose {
Expand All @@ -36,6 +37,11 @@ func Initialize() func(verbose bool) {
provider := newMeterProvider()
otel.SetMeterProvider(provider)

if !verbose {
// Suppress internal OpenTelemetry logs to avoid cluttering the CLI output.
otel.SetLogger(logr.Discard())
}

return func(trace bool) {
if trace {
fmt.Println("Shutdown: uploading metrics...")
Expand Down
Loading